From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@secretlab.ca>,
openezx-devel@lists.openezx.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [RESEND PATCH 4/4] mmc_spi.c: add support for the regulator framework
Date: Thu, 21 Apr 2011 13:40:41 +0100 [thread overview]
Message-ID: <20110421124041.GF11788@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1303388873-15467-5-git-send-email-ospite@studenti.unina.it>
On Thu, Apr 21, 2011 at 02:27:53PM +0200, Antonio Ospite wrote:
> +#ifdef CONFIG_REGULATOR
> + host->vcc = regulator_get(mmc_dev(host->mmc), "vmmc");
> +
> + if (IS_ERR(host->vcc)) {
> + host->vcc = NULL;
> + } else {
> + host->mmc->ocr_avail = mmc_regulator_get_ocrmask(host->vcc);
> + if (host->pdata && host->pdata->ocr_mask)
> + dev_warn(mmc_dev(host->mmc),
> + "ocr_mask/setpower will not be used\n");
> }
> +#endif
Why is this code conditional? The regulator API will stub itself out
(by returning a null pointer, which plays well with your use of null) if
it's disabled. I'm also not seeing any corresponding code to release
the regulator.
next prev parent reply other threads:[~2011-04-21 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1300733202-27316-1-git-send-email-ospite@studenti.unina.it>
2011-04-21 12:27 ` [RESEND PATCH 0/4] mmc_spi: Add support for regulator framework Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 1/4] mmc_spi.c: factor out the check for power capability Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 2/4] mmc_spi.c: factor out the SD card shutdown sequence Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 3/4] mmc_spi.c: factor out a mmc_spi_setpower() function Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 4/4] mmc_spi.c: add support for the regulator framework Antonio Ospite
2011-04-21 12:40 ` Mark Brown [this message]
2011-04-21 12:49 ` Antonio Ospite
2011-04-26 21:21 ` Daniel Ribeiro
2011-04-22 12:43 ` [PATCH v2 " Antonio Ospite
2011-05-06 14:30 ` Antonio Ospite
2011-05-11 10:39 ` [PATCH v3] " Antonio Ospite
[not found] ` <1305110379-17218-1-git-send-email-ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
2011-05-11 13:08 ` Mark Brown
2011-05-11 20:53 ` Antonio Ospite
2011-05-11 20:57 ` Mark Brown
2011-05-18 17:23 ` Antonio Ospite
2011-05-18 19:42 ` Mark Brown
2011-05-23 15:10 ` Antonio Ospite
2011-05-30 9:07 ` Antonio Ospite
2011-05-30 10:14 ` Mark Brown
2011-05-30 10:57 ` Antonio Ospite
2011-05-31 10:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421124041.GF11788@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=openezx-devel@lists.openezx.org \
--cc=ospite@studenti.unina.it \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).