From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@secretlab.ca>,
openezx-devel@lists.openezx.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v3] mmc_spi.c: add support for the regulator framework
Date: Wed, 18 May 2011 12:42:12 -0700 [thread overview]
Message-ID: <20110518194211.GA5077@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110518192320.9dd69cb5.ospite@studenti.unina.it>
On Wed, May 18, 2011 at 07:23:20PM +0200, Antonio Ospite wrote:
> So you mean something like the following:
> mmc_regulator_set_power(...)
> {
Yes.
> 2. Add a proper function with all the needed parameters to abstract
> the actual var names, this would be something like:
> mmc_regulator_set_power(mmc, power_mode, vdd, vcc, pdata)
> and yet checking for pdata->setpower can be tricky as 'setpower'
> is an arbitrary name.
This would be good.
> 3. Move stuff from driver structures to subsystem structures, which I
> don't think is needed in this case.
Though this option is also common - often you get a mix of subsystem and
device specific things with for example a subsystem wide data structure
which the device keeps and passes into a function provided by the
subsystem at appropriate moments.
next prev parent reply other threads:[~2011-05-18 19:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1300733202-27316-1-git-send-email-ospite@studenti.unina.it>
2011-04-21 12:27 ` [RESEND PATCH 0/4] mmc_spi: Add support for regulator framework Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 1/4] mmc_spi.c: factor out the check for power capability Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 2/4] mmc_spi.c: factor out the SD card shutdown sequence Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 3/4] mmc_spi.c: factor out a mmc_spi_setpower() function Antonio Ospite
2011-04-21 12:27 ` [RESEND PATCH 4/4] mmc_spi.c: add support for the regulator framework Antonio Ospite
2011-04-21 12:40 ` Mark Brown
2011-04-21 12:49 ` Antonio Ospite
2011-04-26 21:21 ` Daniel Ribeiro
2011-04-22 12:43 ` [PATCH v2 " Antonio Ospite
2011-05-06 14:30 ` Antonio Ospite
2011-05-11 10:39 ` [PATCH v3] " Antonio Ospite
[not found] ` <1305110379-17218-1-git-send-email-ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
2011-05-11 13:08 ` Mark Brown
2011-05-11 20:53 ` Antonio Ospite
2011-05-11 20:57 ` Mark Brown
2011-05-18 17:23 ` Antonio Ospite
2011-05-18 19:42 ` Mark Brown [this message]
2011-05-23 15:10 ` Antonio Ospite
2011-05-30 9:07 ` Antonio Ospite
2011-05-30 10:14 ` Mark Brown
2011-05-30 10:57 ` Antonio Ospite
2011-05-31 10:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518194211.GA5077@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=openezx-devel@lists.openezx.org \
--cc=ospite@studenti.unina.it \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).