From: Wolfram Sang <w.sang@pengutronix.de>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Magnus Templing <magnus.templing@stericsson.com>,
Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] spi/pl022: timeout on polled transfer
Date: Thu, 19 May 2011 14:44:54 +0200 [thread overview]
Message-ID: <20110519124454.GC2219@pengutronix.de> (raw)
In-Reply-To: <1305807191-11704-1-git-send-email-linus.walleij@stericsson.com>
[-- Attachment #1.1: Type: text/plain, Size: 783 bytes --]
Hi,
> - /* FIXME: insert a timeout so we don't hang here indefinitely */
> - while (pl022->tx < pl022->tx_end || pl022->rx < pl022->rx_end)
> +
> + timeout = jiffies + msecs_to_jiffies(SPI_POLLING_TIMEOUT);
Won't you miss the transfer if you get interrupted here longer than
SPI_POLLING_TIMEOUT?
> + while (pl022->tx < pl022->tx_end || pl022->rx < pl022->rx_end) {
> + if (time_after(jiffies, timeout)) {
> + dev_warn(&pl022->adev->dev,
> + "%s: timeout!\n", __func__);
> + message->state = STATE_ERROR;
> + goto out;
> + }
> readwriter(pl022);
> + }
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-05-19 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 12:13 [PATCH 1/2] spi/pl022: timeout on polled transfer Linus Walleij
2011-05-19 12:44 ` Wolfram Sang [this message]
2011-05-19 13:23 ` Linus Walleij
2011-05-19 14:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519124454.GC2219@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=magnus.templing@stericsson.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).