From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: spi-devel-general@lists.sourceforge.net,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi/pl022: use cpu_relax in the busy loop
Date: Thu, 19 May 2011 12:03:35 -0600 [thread overview]
Message-ID: <20110519180334.GA5013@ponder.secretlab.ca> (raw)
In-Reply-To: <1305828085-25135-1-git-send-email-linus.walleij@stericsson.com>
On Thu, May 19, 2011 at 08:01:25PM +0200, Linus Walleij wrote:
> This relaxes the cpu in the polling busy-wait loop.
>
> Reported-by: Vitaly Wool <vitalywool@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/amba-pl022.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index 18667de..8a2b88a 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -1424,6 +1424,7 @@ static void do_polling_transfer(struct pl022 *pl022)
> message->state = STATE_ERROR;
> goto out;
> }
> + cpu_relax();
> }
>
> /* Update total byte transferred */
> --
> 1.7.3.2
>
prev parent reply other threads:[~2011-05-19 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 18:01 [PATCH] spi/pl022: use cpu_relax in the busy loop Linus Walleij
2011-05-19 18:03 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519180334.GA5013@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).