From: Grant Likely <grant.likely@secretlab.ca>
To: viresh kumar <viresh.linux@gmail.com>
Cc: armando.visconti@st.com, Shiraz HASHIM <shiraz.hashim@st.com>,
linus.walleij@stericsson.com,
linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH] spi/amba-pl022: work in polling or interrupt mode if pl022_dma_probe fails
Date: Thu, 19 May 2011 13:20:26 -0600 [thread overview]
Message-ID: <20110519192026.GM5109@ponder.secretlab.ca> (raw)
In-Reply-To: <BANLkTi=V7Y1boyEVn5feSzUiZbUL5RhJyQ@mail.gmail.com>
On Fri, May 13, 2011 at 06:49:39PM +0530, viresh kumar wrote:
> On 5/13/11, Viresh Kumar <viresh.kumar@st.com> wrote:
> > diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> > index 08de58e..82b98b8 100644
> > --- a/drivers/spi/amba-pl022.c
> > +++ b/drivers/spi/amba-pl022.c
> > @@ -1063,7 +1063,7 @@ static int __init pl022_dma_probe(struct pl022 *pl022)
> > pl022->master_info->dma_filter,
> > pl022->master_info->dma_rx_param);
> > if (!pl022->dma_rx_channel) {
> > - dev_err(&pl022->adev->dev, "no RX DMA channel!\n");
> > + dev_warn(&pl022->adev->dev, "no RX DMA channel!\n");
>
> Sorry, this must be dev_dbg
Please fixup and repost. Add Linus' ack while you're at it. :-)
Thanks,
g.
>
> > goto err_no_rxchan;
> > }
> >
> > @@ -1071,13 +1071,13 @@ static int __init pl022_dma_probe(struct pl022
> > *pl022)
> > pl022->master_info->dma_filter,
> > pl022->master_info->dma_tx_param);
> > if (!pl022->dma_tx_channel) {
> > - dev_err(&pl022->adev->dev, "no TX DMA channel!\n");
> > + dev_warn(&pl022->adev->dev, "no TX DMA channel!\n");
>
> dev_dbg
>
> > goto err_no_txchan;
> > }
> >
> > pl022->dummypage = kmalloc(PAGE_SIZE, GFP_KERNEL);
> > if (!pl022->dummypage) {
> > - dev_err(&pl022->adev->dev, "no DMA dummypage!\n");
> > + dev_warn(&pl022->adev->dev, "no DMA dummypage!\n");
>
> dev_dbg
>
> > goto err_no_dummypage;
> > }
> >
> > @@ -1093,6 +1093,8 @@ err_no_txchan:
> > dma_release_channel(pl022->dma_rx_channel);
> > pl022->dma_rx_channel = NULL;
> > err_no_rxchan:
> > + dev_warn(&pl022->adev->dev,
>
> dev_err
>
> > + "Failed to work in dma mode, work without dma!\n");
> > return -ENODEV;
> > }
> >
>
> Will resend patch on Monday. Till that time, please see if this patch
> with mentioned changes is acceptable or not.
>
> --
> viresh
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-05-19 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 11:54 [PATCH] spi/amba-pl022: work in polling or interrupt mode if pl022_dma_probe fails Viresh Kumar
2011-05-13 13:19 ` viresh kumar
2011-05-19 19:20 ` Grant Likely [this message]
[not found] ` <a105605733caadfea25034ce0b8af73eb907fd33.1305287569.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2011-05-13 14:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519192026.GM5109@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=armando.visconti@st.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shiraz.hashim@st.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).