From: Grant Likely <grant.likely@secretlab.ca>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Wan ZongShun <mcuos.com@gmail.com>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 1/2] spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi_remove
Date: Thu, 19 May 2011 13:31:32 -0600 [thread overview]
Message-ID: <20110519193132.GQ5109@ponder.secretlab.ca> (raw)
In-Reply-To: <1305416008.24670.1.camel@phoenix>
On Sun, May 15, 2011 at 07:33:28AM +0800, Axel Lin wrote:
> Calling spi_bitbang_stop() will also destroy bitbang->workqueue,
> which is created by calling spi_bitbang_start() in nuc900_spi_probe().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
g.
> ---
> drivers/spi/spi_nuc900.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_nuc900.c b/drivers/spi/spi_nuc900.c
> index d5be18b..3cd15f6 100644
> --- a/drivers/spi/spi_nuc900.c
> +++ b/drivers/spi/spi_nuc900.c
> @@ -463,7 +463,7 @@ static int __devexit nuc900_spi_remove(struct platform_device *dev)
>
> platform_set_drvdata(dev, NULL);
>
> - spi_unregister_master(hw->master);
> + spi_bitbang_stop(&hw->bitbang);
>
> clk_disable(hw->clk);
> clk_put(hw->clk);
> --
> 1.7.1
>
>
>
prev parent reply other threads:[~2011-05-19 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 23:33 [PATCH 1/2] spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi_remove Axel Lin
2011-05-14 23:35 ` [PATCH 2/2] spi: spi_s3c24xx: Use spi_bitbang_stop instead of spi_unregister_master in s3c24xx_spi_remove Axel Lin
2011-05-19 19:31 ` Grant Likely
2011-05-19 19:31 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519193132.GQ5109@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).