From: Grant Likely <grant.likely@secretlab.ca>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH] gpio: 74x164: remove unnecessary defines and prototype
Date: Fri, 3 Jun 2011 11:37:25 -0600 [thread overview]
Message-ID: <20110603173725.GC15616@ponder.secretlab.ca> (raw)
In-Reply-To: <201105271635.59593.hartleys@visionengravers.com>
On Fri, May 27, 2011 at 04:35:59PM -0700, H Hartley Sweeten wrote:
> Remove the #define GEN_74X164_GPIO_COUNT since it's only used in
> one place and it's meaning is obvious. Also remove the #define
> GEN_74X164_DRIVER_NAME and use spi->modalias to set the gpio chip's
> label and the string "74x164" for the driver name.
>
> Reorder the code slightly to remove the need to prototype
> gen_74x164_set_value.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
Applied, thanks.
g.
prev parent reply other threads:[~2011-06-03 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 23:35 [PATCH] gpio: 74x164: remove unnecessary defines and prototype H Hartley Sweeten
2011-06-03 17:37 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603173725.GC15616@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).