linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, qi.wang@intel.com,
	yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device ML7213 IOH
Date: Wed, 8 Jun 2011 08:44:26 -0600	[thread overview]
Message-ID: <20110608144426.GA8499@ponder.secretlab.ca> (raw)
In-Reply-To: <4DEF3447.6050209@dsn.okisemi.com>

On Wed, Jun 08, 2011 at 05:35:19PM +0900, Tomoya MORINAGA wrote:
> Hi Grant,
> 
> Why don't you give us your comment/opinion at all for our v4 patch ??
> We have been long waiting since 27-April.

Sorry about that Tomoya.  I got completely overloaded at the end of
April and all of May.  I ended up dropping a lot of patches on the
floor because of it.  I'm not purposefully ignoring you!

I'll look at them now.

g.

> 
> (2011/06/07 14:50), Tomoya MORINAGA wrote:
> > ***Modify Grant's comments.
> >     - Delete unrelated whitespace
> >     - Prevent device driver from accessing platform data
> >     - Add __devinit and __devexit
> >     - Save pdev->dev to pd_dev->dev.parent
> >     - Have own suspend/resume processing in platform_driver.
> >     - Care returned value in pch_spi_init
> >     - Change unregister order
> > 
> > Support ML7213 device of OKI SEMICONDUCTOR.
> > ML7213 is companion chip of Intel Atom E6xx series for IVI(In-Vehicle Infotainment).
> > ML7213 is compatible for Intel EG20T PCH.
> > 
> > Signed-off-by: Tomoya MORINAGA<tomoya-linux@dsn.okisemi.com>
> > ---
> >   drivers/spi/Kconfig            |    5 +-
> >   drivers/spi/spi_topcliff_pch.c |  599 +++++++++++++++++++++-------------------
> >   2 files changed, 317 insertions(+), 287 deletions(-)
> > 
> -- 
> tomoya
> OKI SEMICONDUCTOR CO., LTD.

  reply	other threads:[~2011-06-08 14:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07  5:50 [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device ML7213 IOH Tomoya MORINAGA
2011-06-07  5:50 ` [PATCH/RESEND 2/2] spi_topcliff_pch: DMA support Tomoya MORINAGA
2011-06-08 22:52   ` Grant Likely
2011-06-08  8:35 ` [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device ML7213 IOH Tomoya MORINAGA
2011-06-08 14:44   ` Grant Likely [this message]
2011-06-09  1:04     ` Tomoya MORINAGA
2011-06-08 22:33 ` Grant Likely
     [not found] <1230852546-4561-1-git-send-email-y>
2011-06-07  5:54 ` Tomoya MORINAGA
  -- strict thread matches above, loose matches on Subject: below --
2009-01-01 23:29 Unknown, y
2009-01-01 23:29 y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608144426.GA8499@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=dbrownell@users.sourceforge.net \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tomoya-linux@dsn.okisemi.com \
    --cc=toshiharu-linux@dsn.okisemi.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).