Re: [PATCH] spi-pl022: Add missing return value update

[Grant Likely <grant.likely@secretlab.ca>]

On Mon, Jun 13, 2011 at 04:23:46PM +0530, Virupax Sadashivpetimath wrote:
> Return error on out of range cpsdvsr value.
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>

It looks like this is a bug fix for v3.0, and probably for -stable too, correct?

g.

> ---
>  drivers/spi/spi-pl022.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index 2541705..b3bd8d8 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -1859,6 +1859,7 @@ static int pl022_setup(struct spi_device *spi)
>  	}
>  	if ((clk_freq.cpsdvsr < CPSDVR_MIN)
>  	    || (clk_freq.cpsdvsr > CPSDVR_MAX)) {
> +		status = -EINVAL;
>  		dev_err(&spi->dev,
>  			"cpsdvsr is configured incorrectly\n");
>  		goto err_config_params;
> -- 
> 1.7.4.3
>