From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 3/4] spi/bfin_spi: constify pin array
Date: Fri, 17 Jun 2011 08:37:34 -0600 [thread overview]
Message-ID: <20110617143734.GC21412@ponder.secretlab.ca> (raw)
In-Reply-To: <1308298618-23461-3-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
On Fri, Jun 17, 2011 at 04:16:57AM -0400, Mike Frysinger wrote:
> This array isn't written anywhere, so constify it.
>
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi_bfin5xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
> index 8822bcc..32d900d 100644
> --- a/drivers/spi/spi_bfin5xx.c
> +++ b/drivers/spi/spi_bfin5xx.c
> @@ -964,7 +964,7 @@ static int bfin_spi_transfer(struct spi_device *spi, struct spi_message *msg)
>
> #define MAX_SPI_SSEL 7
>
> -static u16 ssel[][MAX_SPI_SSEL] = {
> +static const u16 ssel[][MAX_SPI_SSEL] = {
> {P_SPI0_SSEL1, P_SPI0_SSEL2, P_SPI0_SSEL3,
> P_SPI0_SSEL4, P_SPI0_SSEL5,
> P_SPI0_SSEL6, P_SPI0_SSEL7},
> --
> 1.7.5.3
>
next prev parent reply other threads:[~2011-06-17 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 8:16 [PATCH 1/4] spi/bfin_spi: fix handling of default bits per word setting Mike Frysinger
[not found] ` <1308298618-23461-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2011-06-17 8:16 ` [PATCH 2/4] spi/bfin_spi: use structs for accessing hardware regs Mike Frysinger
[not found] ` <1308298618-23461-2-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2011-06-17 14:37 ` Grant Likely
2011-06-17 8:16 ` [PATCH 3/4] spi/bfin_spi: constify pin array Mike Frysinger
[not found] ` <1308298618-23461-3-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2011-06-17 14:37 ` Grant Likely [this message]
2011-06-17 8:16 ` [PATCH 4/4] spi/bfin_spi: uninline fat queue funcs Mike Frysinger
[not found] ` <1308298618-23461-4-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2011-06-17 14:37 ` Grant Likely
2011-06-17 8:35 ` [PATCH 1/4 v2] spi/bfin_spi: fix handling of default bits per word setting Mike Frysinger
[not found] ` <1308299737-3806-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2011-06-17 14:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110617143734.GC21412@ponder.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).