From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3/4] spi/bfin_spi: constify pin array Date: Fri, 17 Jun 2011 08:37:34 -0600 Message-ID: <20110617143734.GC21412@ponder.secretlab.ca> References: <1308298618-23461-1-git-send-email-vapier@gentoo.org> <1308298618-23461-3-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, David Brownell , uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org To: Mike Frysinger Return-path: Content-Disposition: inline In-Reply-To: <1308298618-23461-3-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org Errors-To: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Jun 17, 2011 at 04:16:57AM -0400, Mike Frysinger wrote: > This array isn't written anywhere, so constify it. > > Signed-off-by: Mike Frysinger Applied, thanks. g. > --- > drivers/spi/spi_bfin5xx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c > index 8822bcc..32d900d 100644 > --- a/drivers/spi/spi_bfin5xx.c > +++ b/drivers/spi/spi_bfin5xx.c > @@ -964,7 +964,7 @@ static int bfin_spi_transfer(struct spi_device *spi, struct spi_message *msg) > > #define MAX_SPI_SSEL 7 > > -static u16 ssel[][MAX_SPI_SSEL] = { > +static const u16 ssel[][MAX_SPI_SSEL] = { > {P_SPI0_SSEL1, P_SPI0_SSEL2, P_SPI0_SSEL3, > P_SPI0_SSEL4, P_SPI0_SSEL5, > P_SPI0_SSEL6, P_SPI0_SSEL7}, > -- > 1.7.5.3 >