Re: [PATCH 4/4] spi/bfin_spi: uninline fat queue funcs

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Fri, Jun 17, 2011 at 04:16:58AM -0400, Mike Frysinger wrote:
> There's no need for these queue funcs to be inlined, so drop the
> markings.  This shaves off a few hundred duplicated bytes.
> 
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

Applied, thanks.

g.

> ---
>  drivers/spi/spi_bfin5xx.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
> index 32d900d..9057e22 100644
> --- a/drivers/spi/spi_bfin5xx.c
> +++ b/drivers/spi/spi_bfin5xx.c
> @@ -1185,7 +1185,7 @@ static void bfin_spi_cleanup(struct spi_device *spi)
>  	spi_set_ctldata(spi, NULL);
>  }
>  
> -static inline int bfin_spi_init_queue(struct bfin_spi_master_data *drv_data)
> +static int bfin_spi_init_queue(struct bfin_spi_master_data *drv_data)
>  {
>  	INIT_LIST_HEAD(&drv_data->queue);
>  	spin_lock_init(&drv_data->lock);
> @@ -1207,7 +1207,7 @@ static inline int bfin_spi_init_queue(struct bfin_spi_master_data *drv_data)
>  	return 0;
>  }
>  
> -static inline int bfin_spi_start_queue(struct bfin_spi_master_data *drv_data)
> +static int bfin_spi_start_queue(struct bfin_spi_master_data *drv_data)
>  {
>  	unsigned long flags;
>  
> @@ -1229,7 +1229,7 @@ static inline int bfin_spi_start_queue(struct bfin_spi_master_data *drv_data)
>  	return 0;
>  }
>  
> -static inline int bfin_spi_stop_queue(struct bfin_spi_master_data *drv_data)
> +static int bfin_spi_stop_queue(struct bfin_spi_master_data *drv_data)
>  {
>  	unsigned long flags;
>  	unsigned limit = 500;
> @@ -1258,7 +1258,7 @@ static inline int bfin_spi_stop_queue(struct bfin_spi_master_data *drv_data)
>  	return status;
>  }
>  
> -static inline int bfin_spi_destroy_queue(struct bfin_spi_master_data *drv_data)
> +static int bfin_spi_destroy_queue(struct bfin_spi_master_data *drv_data)
>  {
>  	int status;
>  
> -- 
> 1.7.5.3
>