From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH 2/6] spi/imx: use soc name in spi device type naming scheme Date: Fri, 8 Jul 2011 12:58:51 +0200 Message-ID: <20110708105851.GF6069@pengutronix.de> References: <1310113654-25887-1-git-send-email-shawn.guo@linaro.org> <1310113654-25887-3-git-send-email-shawn.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Cc: patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Guo Return-path: Content-Disposition: inline In-Reply-To: <1310113654-25887-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Jul 08, 2011 at 04:27:30PM +0800, Shawn Guo wrote: > Software defined version number is not stable enough to be used > in device type naming scheme. The patch changes it to use implicit > soc name for spi device type definition. In this way, we can easily > align the naming scheme with device tree binding, which comes later. > = > Signed-off-by: Shawn Guo > Cc: Uwe Kleine-K=F6nig > Cc: Sascha Hauer > Cc: Grant Likely > --- > arch/arm/mach-imx/clock-imx25.c | 7 +- > arch/arm/mach-mx5/clock-mx51-mx53.c | 11 +- > arch/arm/plat-mxc/devices/platform-spi_imx.c | 12 +- > drivers/spi/Kconfig | 15 - > drivers/spi/spi-imx.c | 423 ++++++++++++--------= ------ > 5 files changed, 219 insertions(+), 249 deletions(-) Generally this patch is too big for me to get the warm feeling that everything will just work. Renaming from spi_ver_xy to imx_xy is fine, but should be done in smaller steps and where possible not across subsystems. I increasingly see patches touching arch/ and drivers/ and I think there's a high risk of merge conflicts upstream. This will not help making Linus happy. Please try harder to make patches orthogonal and don't try to do too much at once. Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |