From: Grant Likely <grant.likely@secretlab.ca>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
spi-devel-general@lists.sourceforge.net, kernel@pengutronix.de,
shawn.guo@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used
Date: Thu, 15 Sep 2011 15:01:46 -0600 [thread overview]
Message-ID: <20110915210146.GH3523@ponder.secretlab.ca> (raw)
In-Reply-To: <20110915201909.GI11297@pengutronix.de>
On Thu, Sep 15, 2011 at 10:19:09PM +0200, Uwe Kleine-König wrote:
> Hello again,
>
> On Thu, Sep 15, 2011 at 09:52:43PM +0200, Uwe Kleine-König wrote:
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> > index 8ac6542..fa594d6 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -786,9 +786,11 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
> > int cs_gpio = of_get_named_gpio(np, "cs-gpios", i);
> > if (cs_gpio < 0)
> > cs_gpio = mxc_platform_info->chipselect[i];
> > +
> > + spi_imx->chipselect[i] = cs_gpio;
> > if (cs_gpio < 0)
> > continue;
> > - spi_imx->chipselect[i] = cs_gpio;
> > +
> > ret = gpio_request(spi_imx->chipselect[i], DRIVER_NAME);
> > if (ret) {
> > while (i > 0) {
> Having said that I wonder how to specify to use an internal chipselect
> via DT?
It would be done with a blank gpio specifier which is supported by the GPIO binding.
g.
next prev parent reply other threads:[~2011-09-15 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 18:28 [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used Fabio Estevam
[not found] ` <1316111337-13485-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-09-15 19:52 ` Uwe Kleine-König
[not found] ` <20110915195243.GH11297-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-09-15 20:19 ` Uwe Kleine-König
2011-09-15 21:01 ` Grant Likely [this message]
2011-09-15 21:01 ` Grant Likely
[not found] ` <20110915210108.GG3523-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-09-15 21:24 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915210146.GH3523@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@freescale.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).