From: Grant Likely <grant.likely@secretlab.ca>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: pratyush.anand@st.com, rajeev-dlh.kumar@st.com,
bhavna.yadav@st.com, bhupesh.sharma@st.com,
armando.visconti@st.com, linus.walleij@linaro.org,
jassisinghbrar@gmail.com, vipin.kumar@st.com,
shiraz.hashim@st.com, amit.virdi@st.com, vipulkumar.samar@st.com,
viresh.linux@gmail.com, deepak.sikri@st.com,
spi-devel-general@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/6] spi/spi-pl022: Resolve formatting issues
Date: Tue, 20 Sep 2011 11:17:06 -0600 [thread overview]
Message-ID: <20110920171706.GA7781@ponder.secretlab.ca> (raw)
In-Reply-To: <a72e7189be95278b97614fe9ab7d307d422d54e4.1312965741.git.viresh.kumar@st.com>
On Wed, Aug 10, 2011 at 02:20:54PM +0530, Viresh Kumar wrote:
> There were few formatting related issues in code. This patch fixes them.
> Fixes include:
> - Remove extra blank lines
> - align code to 80 cols
> - combine several lines to one line
> - Replace multiple spaces with tabs
> - Remove spaces before labels
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
> @@ -2243,23 +2233,23 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id)
> amba_vcore_disable(adev);
> return 0;
>
> - err_spi_register:
> - err_start_queue:
> - err_init_queue:
> +err_spi_register:
> +err_start_queue:
> +err_init_queue:
> destroy_queue(pl022);
> pl022_dma_remove(pl022);
> free_irq(adev->irq[0], pl022);
> pm_runtime_disable(&adev->dev);
> - err_no_irq:
> +err_no_irq:
> clk_put(pl022->clk);
> - err_no_clk:
> +err_no_clk:
> iounmap(pl022->virtbase);
> - err_no_ioremap:
> +err_no_ioremap:
> amba_release_regions(adev);
> - err_no_ioregion:
> +err_no_ioregion:
> spi_master_put(master);
> - err_no_master:
> - err_no_pdata:
> +err_no_master:
> +err_no_pdata:
These label indentations are actually on purpose. I'll apply the rest
of the patch, but I'm going to remove this hunk. Indenting error
labels by 1 space makes 'diff' show the function name instead of the
label in the context line.
g.
next prev parent reply other threads:[~2011-09-20 17:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 8:50 [PATCH V2 0/6] spi/spi-pl022 fixes Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 1/6] spi/spi-pl022: Resolve formatting issues Viresh Kumar
2011-09-20 17:17 ` Grant Likely [this message]
[not found] ` <cover.1312965741.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2011-08-10 8:50 ` [PATCH V2 2/6] spi/spi-pl022: Use GFP_ATOMIC for allocation from tasklet Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 3/6] spi/spi-pl022: Don't allocate more sg than required Viresh Kumar
2011-08-10 8:54 ` Russell King - ARM Linux
2011-08-10 9:05 ` viresh kumar
2011-08-10 11:42 ` Sergei Shtylyov
2011-08-10 11:46 ` viresh kumar
2011-08-10 8:50 ` [PATCH V2 4/6] spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 5/6] spi/spi-pl022: Call pl022_dma_remove(pl022) only if enable_dma is true Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required Viresh Kumar
2011-08-10 9:00 ` Russell King - ARM Linux
2011-08-10 9:29 ` viresh kumar
2011-08-10 10:01 ` Koul, Vinod
[not found] ` <438BB0150E931F4B9CE701519A4463010871804A15-qq4HA3s+46oFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-08-10 10:14 ` viresh kumar
2011-08-10 10:32 ` Russell King - ARM Linux
2011-08-10 16:53 ` Koul, Vinod
2011-08-10 10:29 ` Russell King - ARM Linux
2011-08-10 10:31 ` Jassi Brar
2011-08-10 10:40 ` Russell King - ARM Linux
2011-08-10 11:24 ` Jassi Brar
2011-08-10 11:54 ` Linus Walleij
2011-08-10 13:16 ` Jassi Brar
2011-08-10 20:58 ` Vinod Koul
2011-08-10 18:59 ` Jassi Brar
2011-08-16 11:55 ` Koul, Vinod
2011-08-16 14:51 ` Jassi Brar
2011-08-19 13:49 ` Koul, Vinod
2011-08-11 12:55 ` Linus Walleij
2011-08-11 14:22 ` Jassi Brar
2011-08-11 14:48 ` Linus Walleij
[not found] ` <CAKnu2MptC8HWCNo6W+X9rawn6MCwAe3DB3B5UcHD1tCD9tA2cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 17:05 ` Jassi Brar
2011-08-11 22:35 ` Koul, Vinod
2011-08-10 10:09 ` Jassi Brar
[not found] ` <CABb+yY0Qvuhrn+FUhWDHMwUjv=nR4MOfLeDfTzG17HXEuu2pmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-10 10:30 ` Russell King - ARM Linux
2011-08-10 10:48 ` Jassi Brar
2011-08-10 11:42 ` [PATCH V3 3/6] spi/spi-pl022: Don't allocate more sg than required Viresh Kumar
2011-09-01 10:04 ` [PATCH V2 0/6] spi/spi-pl022 fixes Viresh Kumar
2011-09-01 10:56 ` Linus Walleij
[not found] ` <CACRpkdYeq9in+U_tyvb=yVuX2t5TnkUSsO+BozUGVJwZVh+4Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-20 11:16 ` Viresh Kumar
2011-09-20 17:23 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920171706.GA7781@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=jassisinghbrar@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).