From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 2/3] spi/pl022: disable the PL022 block when unused Date: Tue, 18 Oct 2011 10:34:31 +0100 Message-ID: <20111018093431.GK21648@n2100.arm.linux.org.uk> References: <1318857154-32160-1-git-send-email-linus.walleij@stericsson.com> <4E9D4337.3030700@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linus WALLEIJ , Linus Walleij , Virupax SADASHIVPETIMATH , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Lee Jones , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" To: Viresh Kumar Return-path: Content-Disposition: inline In-Reply-To: <4E9D4337.3030700-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Oct 18, 2011 at 02:43:27PM +0530, Viresh Kumar wrote: > On 10/17/2011 6:42 PM, Linus WALLEIJ wrote: > > From: Virupax Sadashivpetimath > > > > Make sure we clear the enable bit when the block is not used. > > This will save some energy in certain hardware versions. > > > > Signed-off-by: Virupax Sadashivpetimath > > Signed-off-by: Linus Walleij > > --- > > drivers/spi/spi-pl022.c | 7 ++++++- > > 1 files changed, 6 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c > > index 91700bb..0a1d8ed 100644 > > --- a/drivers/spi/spi-pl022.c > > +++ b/drivers/spi/spi-pl022.c > > @@ -513,7 +513,12 @@ static void giveback(struct pl022 *pl022) > > msg->state = NULL; > > if (msg->complete) > > msg->complete(msg->context); > > - /* This message is completed, so let's turn off the clocks & power */ > > + > > + /* disable the SPI/SSP operation */ > > + writew((readw(SSP_CR1(pl022->virtbase)) & > > + (~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase)); > > + > > + /* This message is completed, so let's turn off the clock! */ > > clk_disable(pl022->clk); > > amba_pclk_disable(pl022->adev); > > amba_vcore_disable(pl022->adev); > > Reviewed-by: Viresh Kumar Note that I have some changes around here in my amba branch (which are dependent on other changes I have for the primecell runtime pm.) ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct