Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Thu, Nov 03, 2011 at 11:10:42PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> in commit 940ab889

This kind of commit message is, frankly, utter crap.

With all the complaints that have been on this mailing list about raw
commit IDs without saying what the commit was, it completely astounds
me that someone in your position (allegedly a co-maintainer of a SoC)
would make such an error.

Please generate a much better commit message.  Maybe something like:

----
Commit 940ab889 (blah blah blah) converted this driver to use
module_platform_driver, but due to the use of platform_driver_probe(),
this resulted in the call to atmel_spi_probe being lost.  Place the
call to this function into the driver structure.

As atmel_spi_probe is marked __init, this will cause a section mismatch
error, so ... <fill this in for the point below>
----

And, you're forgetting to fix this properly (maybe you don't care about
section mismatch errors - are you going to create another patch for that
as well?)  Did you even build-test this patch and pay attention to any
warnings issued, or were you just pleased to get a zImage at the end?

static int __init atmel_spi_probe(struct platform_device *pdev)

__init is not compatible with having a pointer in the platform driver
structure.  It needs to be __devinit.