From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver Date: Thu, 3 Nov 2011 15:18:55 +0000 Message-ID: <20111103151855.GP12913@n2100.arm.linux.org.uk> References: <1320331706-4946-1-git-send-email-plagnioj@jcrosoft.com> <1320333042-24880-1-git-send-email-plagnioj@jcrosoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Grant Likely , spi-devel-general@lists.sourceforge.net, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org To: Jean-Christophe PLAGNIOL-VILLARD Return-path: Content-Disposition: inline In-Reply-To: <1320333042-24880-1-git-send-email-plagnioj@jcrosoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On Thu, Nov 03, 2011 at 11:10:42PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > in commit 940ab889 This kind of commit message is, frankly, utter crap. With all the complaints that have been on this mailing list about raw commit IDs without saying what the commit was, it completely astounds me that someone in your position (allegedly a co-maintainer of a SoC) would make such an error. Please generate a much better commit message. Maybe something like: ---- Commit 940ab889 (blah blah blah) converted this driver to use module_platform_driver, but due to the use of platform_driver_probe(), this resulted in the call to atmel_spi_probe being lost. Place the call to this function into the driver structure. As atmel_spi_probe is marked __init, this will cause a section mismatch error, so ... ---- And, you're forgetting to fix this properly (maybe you don't care about section mismatch errors - are you going to create another patch for that as well?) Did you even build-test this patch and pay attention to any warnings issued, or were you just pleased to get a zImage at the end? static int __init atmel_spi_probe(struct platform_device *pdev) __init is not compatible with having a pointer in the platform driver structure. It needs to be __devinit.