From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver
Date: Thu, 3 Nov 2011 18:08:21 +0000 [thread overview]
Message-ID: <20111103180821.GR12913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111103180338.GN7136@game.jcrosoft.org>
On Thu, Nov 03, 2011 at 07:03:38PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:43 Thu 03 Nov , Russell King - ARM Linux wrote:
> > On Thu, Nov 03, 2011 at 05:51:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > this is an other fix I do not want to fix 2 issue in one commit and I do care
> > > of mismatch erros I fix them all the time I send patch for some rm9200 few
> > > weeks ago
> >
> > It should not be a separate patch - it's all to do with fixing the
> > original problem.
>
> yes when we was supposed to swtch to module_platform_driver we use the .probe
> which is suposed to be __devinit in this case but I was prefering to do it in
> 2 steps
Then do the __devinit transformation _first_ so you don't introduce a new
bug in the middle of your 'fix'.
But I personally think you're just creating needless churn by splitting
this one logical change.
prev parent reply other threads:[~2011-11-03 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 14:48 [PATCH 1/1] atmel/spi: fix missing probe during the switch to module_platform_driver Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 14:55 ` Deepak Saxena
2011-11-03 15:14 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 15:10 ` [PATCH v2] " Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 15:18 ` Russell King - ARM Linux
2011-11-03 16:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:43 ` Russell King - ARM Linux
2011-11-03 18:03 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 18:08 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103180821.GR12913@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).