From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver Date: Thu, 3 Nov 2011 18:08:21 +0000 Message-ID: <20111103180821.GR12913@n2100.arm.linux.org.uk> References: <1320331706-4946-1-git-send-email-plagnioj@jcrosoft.com> <1320333042-24880-1-git-send-email-plagnioj@jcrosoft.com> <20111103151855.GP12913@n2100.arm.linux.org.uk> <20111103165113.GL7136@game.jcrosoft.org> <20111103174338.GQ12913@n2100.arm.linux.org.uk> <20111103180338.GN7136@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Grant Likely , spi-devel-general@lists.sourceforge.net, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org To: Jean-Christophe PLAGNIOL-VILLARD Return-path: Content-Disposition: inline In-Reply-To: <20111103180338.GN7136@game.jcrosoft.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On Thu, Nov 03, 2011 at 07:03:38PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:43 Thu 03 Nov , Russell King - ARM Linux wrote: > > On Thu, Nov 03, 2011 at 05:51:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > this is an other fix I do not want to fix 2 issue in one commit and I do care > > > of mismatch erros I fix them all the time I send patch for some rm9200 few > > > weeks ago > > > > It should not be a separate patch - it's all to do with fixing the > > original problem. > > yes when we was supposed to swtch to module_platform_driver we use the .probe > which is suposed to be __devinit in this case but I was prefering to do it in > 2 steps Then do the __devinit transformation _first_ so you don't introduce a new bug in the middle of your 'fix'. But I personally think you're just creating needless churn by splitting this one logical change.