linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
To: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant
Subject: Re: [PATCH] spi: nuc900: Include linux/module.h
Date: Wed, 23 Nov 2011 22:16:19 -0500	[thread overview]
Message-ID: <20111124031619.GC10880@windriver.com> (raw)
In-Reply-To: <1322104251.16201.8.camel@phoenix>

[[PATCH] spi: nuc900: Include linux/module.h] On 24/11/2011 (Thu 11:10) Axel Lin wrote:

> Include linux/module.h to fix below build error:

Looks fine to me ; I'll assume that this is going upstream via the
nuc900 maintainer since the module split up is old news at this point
in time.

Thanks,
Paul.

> 
>   CC      drivers/spi/spi-nuc900.o
> drivers/spi/spi-nuc900.c:484: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/spi/spi-nuc900.c:489: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:489: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:489: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/spi/spi-nuc900.c:489: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:490: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:490: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:490: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/spi/spi-nuc900.c:490: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:491: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:491: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:491: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/spi/spi-nuc900.c:491: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:492: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:492: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:492: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
> drivers/spi/spi-nuc900.c:492: warning: function declaration isn't a prototype
> make[2]: *** [drivers/spi/spi-nuc900.o] Error 1
> make[1]: *** [drivers/spi] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/spi/spi-nuc900.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
> index 21c70b2..182e9c8 100644
> --- a/drivers/spi/spi-nuc900.c
> +++ b/drivers/spi/spi-nuc900.c
> @@ -8,6 +8,7 @@
>   *
>   */
>  
> +#include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/spinlock.h>
>  #include <linux/workqueue.h>
> -- 
> 1.7.5.4
> 
> 
> 

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d

      reply	other threads:[~2011-11-24  3:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24  3:10 [PATCH] spi: nuc900: Include linux/module.h Axel Lin
2011-11-24  3:16 ` Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111124031619.GC10880@windriver.com \
    --to=paul.gortmaker-cwa4wttnnzf54taoqtywwq@public.gmane.org \
    --cc=axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).