[PATCH] spi-topcliff-pch: Fix count calculation issue

[PATCH] spi-topcliff-pch: Fix count calculation issue

[Tomoya MORINAGA]

Currently, count value is not correct more than len=8193 like below.

len	Current-cnt	New-cnt		Anticipated-cnt
4095	1		1		1
4096	1		1		1
4097	2		2		2

8191	2		2		2
8192	2		2		2
8193	2(NG)		3		3

12287	3		3		3
12288	3		3		3
12289	3(NG)		4		4

This patch fixes the issue.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/spi/spi-topcliff-pch.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 9fb0541..08b5f31 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1247,7 +1247,9 @@ static void pch_spi_process_messages(struct work_struct *pwork)
 		}
 		spin_unlock(&data->lock);
 
-		cnt = data->cur_trans->len / (PCH_BUF_SIZE + 1) + 1;
+		if (!data->cur_trans->len)
+			goto out;
+		cnt = (data->cur_trans->len - 1) / PCH_BUF_SIZE + 1;
 		data->save_total_len = data->cur_trans->len;
 		if (data->use_dma) {
 			int i;
-- 
1.7.4.4

Re: [PATCH] spi-topcliff-pch: Fix count calculation issue

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hi,

On Thu, Nov 17, 2011 at 03:37:21PM +0900, Tomoya MORINAGA wrote:
> Currently, count value is not correct more than len=8193 like below.
> 
> len	Current-cnt	New-cnt		Anticipated-cnt
> 4095	1		1		1
> 4096	1		1		1
> 4097	2		2		2
> 
> 8191	2		2		2
> 8192	2		2		2
> 8193	2(NG)		3		3
> 
> 12287	3		3		3
> 12288	3		3		3
> 12289	3(NG)		4		4
> 
> This patch fixes the issue.
> 
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>

Which branch is this patch based on?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] spi-topcliff-pch: Fix count calculation issue

[Tomoya MORINAGA]

2011/12/8, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>:
>>
>> Signed-off-by: Tomoya MORINAGA <tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Which branch is this patch based on?

This patch was created for linux-3.2.
However, other patches which have dependency are not sent to upstream yet.
So, I'll send the patch series again.
Sorry, for inconvenience.

thanks,
tomoya

------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/