From: Wolfram Sang <w.sang@pengutronix.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] spi: use gpio_request_one() instead of spi_gpio_alloc() helper function
Date: Thu, 8 Dec 2011 09:46:29 +0100 [thread overview]
Message-ID: <20111208084629.GA23908@pengutronix.de> (raw)
In-Reply-To: <CAF+7xWmnYsjM-mcx=2pvKavE6RAnLFv2Ey0N1+0_n46G3Km27w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Thu, Dec 08, 2011 at 09:36:23AM +0800, Axel Lin wrote:
> 2011/12/8 Wolfram Sang <w.sang@pengutronix.de>:
> > On Mon, Dec 05, 2011 at 03:50:47PM +0800, Axel Lin wrote:
> >> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >
> > This will make the driver depend on GPIOLIB, currently it depends only
> > on GENERIC_GPIO. That needs to be addressed and made sure it won't cause
> > a regression for the in-kernel users.
> >
> Ah. You are right.
> GPIOLIB can be optional or not available at all in some
> architecture/configurations.
> Thanks for your review.
Note that there are plans to make GPIOLIB mandatory, but we are not there yet.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-12-08 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 7:50 [PATCH] spi: use gpio_request_one() instead of spi_gpio_alloc() helper function Axel Lin
2011-12-06 1:27 ` Denis Kuzmenko
2011-12-07 21:21 ` Wolfram Sang
2011-12-08 1:36 ` Axel Lin
2011-12-08 8:46 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208084629.GA23908@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).