From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA
Date: Mon, 2 Jan 2012 02:01:47 -0700 [thread overview]
Message-ID: <20120102090147.GN18381@ponder.secretlab.ca> (raw)
In-Reply-To: <1324598277-4751-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
On Thu, Dec 22, 2011 at 03:57:57PM -0800, Olof Johansson wrote:
> It's unlikely that anyone ever wants to turn off SYSTEM_DMA, but just in
> case, it makes more sense to have the driver depend on it than select it.
>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Applied, thanks
g.
> ---
> drivers/spi/Kconfig | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 3d292be..326f77a 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -332,8 +332,7 @@ config SPI_STMP3XXX
>
> config SPI_TEGRA
> tristate "Nvidia Tegra SPI controller"
> - depends on ARCH_TEGRA
> - select TEGRA_SYSTEM_DMA
> + depends on ARCH_TEGRA && TEGRA_SYSTEM_DMA
> help
> SPI driver for NVidia Tegra SoCs
>
> --
> 1.7.8.GIT
>
prev parent reply other threads:[~2012-01-02 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 23:57 [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA Olof Johansson
[not found] ` <1324598277-4751-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2012-01-02 9:01 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102090147.GN18381@ponder.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).