linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA
@ 2011-12-22 23:57 Olof Johansson
       [not found] ` <1324598277-4751-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2011-12-22 23:57 UTC (permalink / raw)
  To: Grant Likely, Sascha Hauer
  Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Olof Johansson

It's unlikely that anyone ever wants to turn off SYSTEM_DMA, but just in
case, it makes more sense to have the driver depend on it than select it.

Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---
 drivers/spi/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 3d292be..326f77a 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -332,8 +332,7 @@ config SPI_STMP3XXX
 
 config SPI_TEGRA
 	tristate "Nvidia Tegra SPI controller"
-	depends on ARCH_TEGRA
-	select TEGRA_SYSTEM_DMA
+	depends on ARCH_TEGRA && TEGRA_SYSTEM_DMA
 	help
 	  SPI driver for NVidia Tegra SoCs
 
-- 
1.7.8.GIT

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA
       [not found] ` <1324598277-4751-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
@ 2012-01-02  9:01   ` Grant Likely
  0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-01-02  9:01 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Sascha Hauer, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

On Thu, Dec 22, 2011 at 03:57:57PM -0800, Olof Johansson wrote:
> It's unlikely that anyone ever wants to turn off SYSTEM_DMA, but just in
> case, it makes more sense to have the driver depend on it than select it.
> 
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

Applied, thanks

g.

> ---
>  drivers/spi/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 3d292be..326f77a 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -332,8 +332,7 @@ config SPI_STMP3XXX
>  
>  config SPI_TEGRA
>  	tristate "Nvidia Tegra SPI controller"
> -	depends on ARCH_TEGRA
> -	select TEGRA_SYSTEM_DMA
> +	depends on ARCH_TEGRA && TEGRA_SYSTEM_DMA
>  	help
>  	  SPI driver for NVidia Tegra SoCs
>  
> -- 
> 1.7.8.GIT
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-02  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-22 23:57 [PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA Olof Johansson
     [not found] ` <1324598277-4751-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2012-01-02  9:01   ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).