From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
spi-devel-general@lists.sourceforge.net,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts
Date: Sun, 29 Jan 2012 21:40:29 +0000 [thread overview]
Message-ID: <20120129214028.GC2994@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAM=Q2ctA6o0wW4LMW=Jpe7HPGbm4S-UySURToXrC1r4kOe08Rg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Sat, Jan 28, 2012 at 10:30:36PM +0530, Shubhrajyoti Datta wrote:
Please delete irrelevant context from your replies.
> > + ret = request_irq(irq, s3c64xx_spi_irq, 0, "spi-s3c64xx", sdd);
> Could we have a threaded irq instead and there are prints and that may get
> executed in interrupt context.
So, clearly we *could*. However I think that's not going to be as
helpful. These errors are never supposed to happen (and if they do
indicate a fairly serious problem) so the performance impact shouldn't
be our primary concern and if they do happen then my suspicion is that
the timing information will be very important. I expect that knowing
exactly when the error occurred is likely to help diagnose what caused
it by virtue of knowing what other things were going on in the system at
that time.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-29 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 13:23 [PATCH 0/3] spi/s3c64xx diagnostic and PM updates Mark Brown
2012-01-21 13:24 ` [PATCH 1/3] spi/s3c64xx: Log error interrupts Mark Brown
2012-01-21 13:24 ` [PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops Mark Brown
2012-01-21 13:24 ` [PATCH 3/3] spi/s3c64xx: Implement runtime PM support Mark Brown
2012-01-21 13:41 ` Bill Gatliff
2012-01-21 14:18 ` Mark Brown
2012-01-21 15:27 ` [PATCH 1/3] spi/s3c64xx: Log error interrupts Sylwester Nawrocki
[not found] ` <4F1AD954.9030303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-21 15:29 ` Mark Brown
[not found] ` <20120121152947.GD10751-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-21 16:42 ` Sylwester Nawrocki
[not found] ` <1327152265-10789-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-28 17:00 ` Shubhrajyoti Datta
2012-01-29 21:40 ` Mark Brown [this message]
2012-02-01 6:20 ` Shubhrajyoti Datta
2012-01-21 14:27 ` [PATCH 0/3] spi/s3c64xx diagnostic and PM updates Grant Likely
2012-01-21 15:13 ` Mark Brown
2012-01-30 15:37 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 21:01 [PATCH 1/3] spi/s3c64xx: Log error interrupts Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129214028.GC2994@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=omaplinuxkernel@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).