* [PATCH] spi/nuc900: Remove unnecessary memset of struct nuc900_spi
@ 2012-02-01 12:33 Tobias Klauser
[not found] ` <1328099622-14058-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2012-02-01 12:33 UTC (permalink / raw)
To: Wan ZongShun, Grant Likely
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
The memory allocated using kzalloc by spi_alloc_master so it doesn't
need to be set to 0 again.
Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
---
drivers/spi/spi-nuc900.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
index 182e9c8..dae8be2 100644
--- a/drivers/spi/spi-nuc900.c
+++ b/drivers/spi/spi-nuc900.c
@@ -360,8 +360,6 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev)
}
hw = spi_master_get_devdata(master);
- memset(hw, 0, sizeof(struct nuc900_spi));
-
hw->master = spi_master_get(master);
hw->pdata = pdev->dev.platform_data;
hw->dev = &pdev->dev;
--
1.7.5.4
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/nuc900: Remove unnecessary memset of struct nuc900_spi
[not found] ` <1328099622-14058-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
@ 2012-02-02 0:11 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-02-02 0:11 UTC (permalink / raw)
To: Tobias Klauser
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Wed, Feb 01, 2012 at 01:33:42PM +0100, Tobias Klauser wrote:
> The memory allocated using kzalloc by spi_alloc_master so it doesn't
> need to be set to 0 again.
>
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
Merged, thanks.
g.
> ---
> drivers/spi/spi-nuc900.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
> index 182e9c8..dae8be2 100644
> --- a/drivers/spi/spi-nuc900.c
> +++ b/drivers/spi/spi-nuc900.c
> @@ -360,8 +360,6 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev)
> }
>
> hw = spi_master_get_devdata(master);
> - memset(hw, 0, sizeof(struct nuc900_spi));
> -
> hw->master = spi_master_get(master);
> hw->pdata = pdev->dev.platform_data;
> hw->dev = &pdev->dev;
> --
> 1.7.5.4
>
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-02 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-01 12:33 [PATCH] spi/nuc900: Remove unnecessary memset of struct nuc900_spi Tobias Klauser
[not found] ` <1328099622-14058-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2012-02-02 0:11 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).