From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] spi/nuc900: Remove unnecessary memset of struct nuc900_spi Date: Wed, 1 Feb 2012 17:11:07 -0700 Message-ID: <20120202001107.GC15343@ponder.secretlab.ca> References: <1328099622-14058-1-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Tobias Klauser Return-path: Content-Disposition: inline In-Reply-To: <1328099622-14058-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Feb 01, 2012 at 01:33:42PM +0100, Tobias Klauser wrote: > The memory allocated using kzalloc by spi_alloc_master so it doesn't > need to be set to 0 again. > > Signed-off-by: Tobias Klauser Merged, thanks. g. > --- > drivers/spi/spi-nuc900.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c > index 182e9c8..dae8be2 100644 > --- a/drivers/spi/spi-nuc900.c > +++ b/drivers/spi/spi-nuc900.c > @@ -360,8 +360,6 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev) > } > > hw = spi_master_get_devdata(master); > - memset(hw, 0, sizeof(struct nuc900_spi)); > - > hw->master = spi_master_get(master); > hw->pdata = pdev->dev.platform_data; > hw->dev = &pdev->dev; > -- > 1.7.5.4 > ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d