From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Barry Song <21cnbao@gmail.com>
Cc: workgroup.linux@csr.com, Zhiwu Song <zhiwu.song@csr.com>,
grant.likely@secretlab.ca, Barry Song <Baohua.Song@csr.com>,
spi-devel-general@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] SPI: add CSR SiRFprimaII SPI controller driver
Date: Wed, 8 Feb 2012 17:26:39 +0100 [thread overview]
Message-ID: <20120208162639.GJ15647@game.jcrosoft.org> (raw)
In-Reply-To: <1328717446-4526-1-git-send-email-21cnbao@gmail.com>
+
> +static int spi_sirfsoc_setup(struct spi_device *spi)
> +{
> + struct spi_bitbang *bitbang;
> + struct sirfsoc_spi *sspi;
> +
> + if (!spi->max_speed_hz)
> + return -EINVAL;
> +
> + sspi = spi_master_get_devdata(spi->master);
> + bitbang = &sspi->bitbang;
why do you need this?
> +
> + if (!spi->bits_per_word)
> + spi->bits_per_word = 8;
> +
> + return spi_sirfsoc_setup_transfer(spi, NULL);
> +}
Best Regards,
J.
next prev parent reply other threads:[~2012-02-08 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:10 [PATCH v3] SPI: add CSR SiRFprimaII SPI controller driver Barry Song
2012-02-08 16:26 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-02-09 3:38 ` Barry Song
[not found] ` <1328717446-4526-1-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-09 15:23 ` Grant Likely
[not found] ` <20120209152340.GB11249-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-02-10 5:06 ` Barry Song
[not found] ` <5EB3BFCD089AD643B9BB63439F5FD5E99CB93BC5-W2enlP78h2wYZnBWG7VmBdnKn0HB1kRyVQQcQy+6Uvc@public.gmane.org>
2012-02-13 3:32 ` Barry Song
2012-02-13 19:40 ` Grant Likely
[not found] ` <20120213194014.GG11077-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-02-14 1:58 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208162639.GJ15647@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=workgroup.linux@csr.com \
--cc=zhiwu.song@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).