From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] spi: Mark spi_register_board_info() __devinit Date: Fri, 09 Mar 2012 14:42:03 -0700 Message-ID: <20120309214203.B23983E0880@localhost> References: <1329524609-1777-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, Mark Brown To: Mark Brown Return-path: In-Reply-To: <1329524609-1777-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, 17 Feb 2012 16:23:29 -0800, Mark Brown wrote: > Some systems have SPI devices located on plugin modules which are > enumerated at runtime as devices. The drivers for these plugin modules > need to register their SPI devices at probe() time so want to be able > to call spi_register_board_info() but that function is currently marked > as __init rather than __devinit so this usage isn't legal. Change the > annotation to __devinit to handle this. > > Signed-off-by: Mark Brown Applied, thanks. g. > --- > drivers/spi/spi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 909e303..0c833a9 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -484,7 +484,7 @@ static void spi_match_master_to_boardinfo(struct spi_master *master, > * The board info passed can safely be __initdata ... but be careful of > * any embedded pointers (platform_data, etc), they're copied as-is. > */ > -int __init > +int __devinit > spi_register_board_info(struct spi_board_info const *info, unsigned n) > { > struct boardinfo *bi; > -- > 1.7.9 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/