From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [patch] spi: release lock on error path in spi_pump_messages() Date: Sat, 10 Mar 2012 19:43:07 -0700 Message-ID: <20120311024307.AA5E33E0950@localhost> References: <20120310085729.GB4647@elgon.mountain> <4F5B2113.3060103@bfs.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: wharms-fPG8STNUNVg@public.gmane.org, Dan Carpenter Return-path: In-Reply-To: <4F5B2113.3060103-fPG8STNUNVg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sat, 10 Mar 2012 10:38:27 +0100, walter harms wrote: > > > Am 10.03.2012 09:57, schrieb Dan Carpenter: > > We should release the lock here and enable IRQs before returning. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > > index 5ae1e84..ab1bdce 100644 > > --- a/drivers/spi/spi.c > > +++ b/drivers/spi/spi.c > > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work) > > if (ret) { > > dev_err(&master->dev, > > "failed to unprepare transfer hardware\n"); > > + spin_unlock_irqrestore(&master->queue_lock, flags); > > return; > > } > > } > > > hi Dan, > do you want to protect dev_err() by a spn_lock ? Applied, after moving unlock above the dev_err. g. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/