From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wharms-fPG8STNUNVg@public.gmane.org
Subject: Re: [patch] spi: release lock on error path in spi_pump_messages()
Date: Sun, 11 Mar 2012 07:02:40 -0600 [thread overview]
Message-ID: <20120311130240.2DB083E0892@localhost> (raw)
In-Reply-To: <20120311062059.GB3337@mwanda>
On Sun, 11 Mar 2012 09:20:59 +0300, Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> On Sat, Mar 10, 2012 at 07:43:07PM -0700, Grant Likely wrote:
> > On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <wharms-fPG8STNUNVg@public.gmane.org> wrote:
> > > hi Dan,
> > > do you want to protect dev_err() by a spn_lock ?
> >
> > Applied, after moving unlock above the dev_err.
> >
>
> Thanks.
>
> I was going to resend this with Walter's change btw. I wasn't going
> to ignore his review comments.
I assumed you would. It was just simpler for me to pick it up with the
trivial change.
g.
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
prev parent reply other threads:[~2012-03-11 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 8:57 [patch] spi: release lock on error path in spi_pump_messages() Dan Carpenter
[not found] ` <20120310085729.GB4647-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-03-10 9:38 ` walter harms
[not found] ` <4F5B2113.3060103-fPG8STNUNVg@public.gmane.org>
2012-03-11 2:43 ` Grant Likely
2012-03-11 6:20 ` Dan Carpenter
2012-03-11 13:02 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311130240.2DB083E0892@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=wharms-fPG8STNUNVg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).