* [PATCH] spi: s3c64xx: Fix build
@ 2012-03-14 16:52 Mark Brown
2012-03-15 9:32 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-03-14 16:52 UTC (permalink / raw)
To: Boojin Kim, Kyoungil Kim, Grant Likely
Cc: spi-devel-general, linux-samsung-soc, Mark Brown
Commit 054ebc (spi: Compatibility with direction which is used in samsung
DMA operation) does not build as one hunk adds a brace to the first branch
of an if statement without adding at least the correspoding close. Remove
the unwanted brace.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/spi/spi-s3c64xx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index c40d118..3180100 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -264,7 +264,7 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
struct s3c64xx_spi_driver_data *sdd;
struct samsung_dma_prep_info info;
- if (dma->direction == DMA_DEV_TO_MEM) {
+ if (dma->direction == DMA_DEV_TO_MEM)
sdd = container_of((void *)dma,
struct s3c64xx_spi_driver_data, rx_dma);
else
--
1.7.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] spi: s3c64xx: Fix build
2012-03-14 16:52 [PATCH] spi: s3c64xx: Fix build Mark Brown
@ 2012-03-15 9:32 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-03-15 9:32 UTC (permalink / raw)
To: Mark Brown, Boojin Kim, Kyoungil Kim
Cc: spi-devel-general, linux-samsung-soc, Mark Brown
On Wed, 14 Mar 2012 16:52:14 +0000, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> Commit 054ebc (spi: Compatibility with direction which is used in samsung
> DMA operation) does not build as one hunk adds a brace to the first branch
> of an if statement without adding at least the correspoding close. Remove
> the unwanted brace.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thanks.
g.
> ---
> drivers/spi/spi-s3c64xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index c40d118..3180100 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -264,7 +264,7 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
> struct s3c64xx_spi_driver_data *sdd;
> struct samsung_dma_prep_info info;
>
> - if (dma->direction == DMA_DEV_TO_MEM) {
> + if (dma->direction == DMA_DEV_TO_MEM)
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, rx_dma);
> else
> --
> 1.7.9.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-15 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 16:52 [PATCH] spi: s3c64xx: Fix build Mark Brown
2012-03-15 9:32 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).