Re: [PATCH v3 1/6] regmap: add support for 7_25 format

[Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>]

On Thursday, March 15, 2012 09:44:44 PM Mark Brown wrote:
> On Thu, Mar 15, 2012 at 07:43:05AM +1100, Marc Reilly wrote:
> > This adds support for devices with 7 address bits and 25 data bits.
> > The initial intended user for this are the mc13xxx mfds in spi mode.
> > (The 25th data bit is actually a dummy bit)
> > 
> > Signed-off-by: Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
> 
> It looks like this should be using the pad_bits parameter, though
> currently we only actually support pad bytes and integer sized register
> values.  Ugh.  We also have some entertainment because this device
> contains a touchscreen so I imagine you want readback but devices using
> odd register sizes don't do readback right now.

Ah, so this way definetly won't work. We definitely need to read the device 
registers.

> 
> What I think we want to do here is use pad_bits then internally to the
> API notice that reg_bits + pad_bits is a byte and therefore set up for 8
> bit registers and set a new value reg_shift in the map which shifts the
> register address left, either teaching the register format functions
> about it or just making a new one.  This should work better from a
> framework point of view.

Ok. 

Cheers,
Marc
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure