Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

["Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Mon, Mar 26, 2012 at 03:13:52PM -0300, Fabio Estevam wrote:
> Structure struct spi_imx_data is defined twice.
> 
> Remove one of its definition.
In my version of drivers/spi/spi-imx.c struct spi_imx_data is only
defined once. I guess you wanted to say "forward declaration".

> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/spi/spi-imx.c |   20 +++++++++-----------
>  1 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 31054e3..f1f6700 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -68,17 +68,6 @@ enum spi_imx_devtype {
>  	IMX51_ECSPI,	/* ECSPI on i.mx51 and later */
>  };
>  
> -struct spi_imx_data;
> -
> -struct spi_imx_devtype_data {
> -	void (*intctrl)(struct spi_imx_data *, int);
> -	int (*config)(struct spi_imx_data *, struct spi_imx_config *);
> -	void (*trigger)(struct spi_imx_data *);
> -	int (*rx_available)(struct spi_imx_data *);
> -	void (*reset)(struct spi_imx_data *);
> -	enum spi_imx_devtype devtype;
> -};
> -
>  struct spi_imx_data {
>  	struct spi_bitbang bitbang;
>  
> @@ -99,6 +88,15 @@ struct spi_imx_data {
>  	int chipselect[0];
>  };
>  
> +struct spi_imx_devtype_data {
> +	void (*intctrl)(struct spi_imx_data *, int);
> +	int (*config)(struct spi_imx_data *, struct spi_imx_config *);
> +	void (*trigger)(struct spi_imx_data *);
> +	int (*rx_available)(struct spi_imx_data *);
> +	void (*reset)(struct spi_imx_data *);
> +	enum spi_imx_devtype devtype;
> +};
> +
Does this really work? struct spi_imx_data has a member

	struct spi_imx_devtype_data *devtype_data;

. So when reordering you can drop the forward definition of
spi_imx_data, but don't you need another one for spi_imx_devtype_data?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure