From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition
Date: Tue, 27 Mar 2012 09:01:35 +0200 [thread overview]
Message-ID: <20120327070135.GN15647@pengutronix.de> (raw)
In-Reply-To: <4F7123BE.8090608-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Hello Fabio,
On Mon, Mar 26, 2012 at 11:19:42PM -0300, Fabio Estevam wrote:
> On 3/26/2012 5:59 PM, Uwe Kleine-König wrote:
>
> > In my version of drivers/spi/spi-imx.c struct spi_imx_data is only
> > defined once. I guess you wanted to say "forward declaration".
>
> Yes, correct.
>
> ...
>
> > Does this really work? struct spi_imx_data has a member
>
> Yes, tested it on a mx31pdk board.
Strange, I can confirm it compiles without warnings. Even sparse doesn't
complain about it. I don't understand it. *shrug*
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
next prev parent reply other threads:[~2012-03-27 7:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 18:13 [PATCH] spi-imx: Remove duplicate spi_imx_data definition Fabio Estevam
[not found] ` <1332785632-17799-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-03-26 18:46 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cvL+Dac=Q1XmSUOLZGqK2zVdYd6nzQc-Tgeywois8rrxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-26 19:04 ` Fabio Estevam
[not found] ` <4F70BDD4.5010003-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-03-26 19:02 ` Shubhrajyoti Datta
2012-03-26 20:59 ` Uwe Kleine-König
[not found] ` <20120326205940.GM15647-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-27 2:19 ` Fabio Estevam
[not found] ` <4F7123BE.8090608-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-03-27 7:01 ` Uwe Kleine-König [this message]
[not found] ` <20120327070135.GN15647-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-27 22:04 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327070135.GN15647@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).