From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition Date: Tue, 27 Mar 2012 09:01:35 +0200 Message-ID: <20120327070135.GN15647@pengutronix.de> References: <1332785632-17799-1-git-send-email-fabio.estevam@freescale.com> <20120326205940.GM15647@pengutronix.de> <4F7123BE.8090608@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org To: Fabio Estevam Return-path: Content-Disposition: inline In-Reply-To: <4F7123BE.8090608-KZfg59tc24xl57MIdRCFDg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Hello Fabio, On Mon, Mar 26, 2012 at 11:19:42PM -0300, Fabio Estevam wrote: > On 3/26/2012 5:59 PM, Uwe Kleine-K=F6nig wrote: > = > > In my version of drivers/spi/spi-imx.c struct spi_imx_data is only > > defined once. I guess you wanted to say "forward declaration". > = > Yes, correct. > = > ... > = > > Does this really work? struct spi_imx_data has a member > = > Yes, tested it on a mx31pdk board. Strange, I can confirm it compiles without warnings. Even sparse doesn't complain about it. I don't understand it. *shrug* Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ---------------------------------------------------------------------------= --- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here = http://p.sf.net/sfu/sfd2d-msazure