From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3/6] spi/bfin_spi: drop bits_per_word from client data Date: Fri, 27 Apr 2012 12:21:40 -0600 Message-ID: <20120427182140.B76A63E171B@localhost> References: <1335219493-24184-1-git-send-email-scott.jiang.linux@gmail.com> <1335219493-24184-3-git-send-email-scott.jiang.linux@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Scott Jiang , Mike Frysinger To: Scott Jiang , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org Return-path: In-Reply-To: <1335219493-24184-3-git-send-email-scott.jiang.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Mon, 23 Apr 2012 18:18:10 -0400, Scott Jiang wrote: > No other SPI controller has this field, and SPI clients should be setting > this up in their own drivers. So drop it from the Blackfin controller to > keep people from using it. > > Signed-off-by: Mike Frysinger > Signed-off-by: Scott Jiang Applied, thanks. g. > --- > drivers/spi/spi-bfin5xx.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c > index 3b83ff8..c0cdcb7 100644 > --- a/drivers/spi/spi-bfin5xx.c > +++ b/drivers/spi/spi-bfin5xx.c > @@ -1026,7 +1026,6 @@ static int bfin_spi_setup(struct spi_device *spi) > chip->cs_chg_udelay = chip_info->cs_chg_udelay; > chip->idle_tx_val = chip_info->idle_tx_val; > chip->pio_interrupt = chip_info->pio_interrupt; > - spi->bits_per_word = chip_info->bits_per_word; > } else { > /* force a default base state */ > chip->ctl_reg &= bfin_ctl_reg; > -- > 1.7.0.4 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/