From: Grant Likely <grant.likely@secretlab.ca>
To: Thomas Abraham <thomas.abraham@linaro.org>,
spi-devel-general@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com,
kgene.kim@samsung.com, jaswinder.singh@linaro.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 6/6] spi: s3c64xx: add device tree support
Date: Sat, 19 May 2012 23:10:26 -0600 [thread overview]
Message-ID: <20120520051026.77D0C3E03B8@localhost> (raw)
In-Reply-To: <1337333613-6216-7-git-send-email-thomas.abraham@linaro.org>
On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham <thomas.abraham@linaro.org> wrote:
> Add support for device based discovery.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> Acked-by: Jaswinder Singh <jaswinder.singh@linaro.org>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
... but one nitpick below...
> +#ifdef CONFIG_OF
> +static const struct of_device_id s3c64xx_spi_dt_match[] = {
> + { .compatible = "samsung,exynos4210-spi",
> + .data = (void *)EXYNOS4_SPI_PORT_CONFIG,
This looks completely backwards. EXYNOS4_SPI_PORT_CONFIG casts a
pointer to a kernel_ulong_t, and this casts it right back to a
pointer. The cast should be removed entirely from the macro, and the
platform_device_id table should have the cast from pointer to ulong.
g.
next prev parent reply other threads:[~2012-05-20 5:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 9:33 [PATCH v2 0/6] spi: s3c64xx: add support for device tree Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro Thomas Abraham
2012-05-20 5:03 ` Grant Likely
2012-05-18 9:33 ` [PATCH v2 2/6] spi: s3c64xx: move controller information into driver data Thomas Abraham
2012-05-20 5:06 ` Grant Likely
2012-05-24 7:18 ` Kukjin Kim
2012-05-24 8:43 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 3/6] ARM: Samsung: Remove pdev pointer paremeter from spi gpio setup functions Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function Thomas Abraham
2012-05-20 9:21 ` Mark Brown
2012-05-30 7:28 ` Olof Johansson
2012-05-30 7:47 ` Thomas Abraham
2012-05-30 9:34 ` Mark Brown
2012-05-30 10:05 ` Thomas Abraham
2012-05-30 10:13 ` Mark Brown
[not found] ` <20120530101326.GF9947-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-31 2:05 ` Thomas Abraham
2012-05-31 11:36 ` Mark Brown
[not found] ` <20120531113659.GB2666-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-01 2:47 ` Thomas Abraham
2012-06-01 12:39 ` Mark Brown
2012-06-03 9:29 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data Thomas Abraham
2012-05-20 5:07 ` Grant Likely
2012-05-18 9:33 ` [PATCH v2 6/6] spi: s3c64xx: add device tree support Thomas Abraham
2012-05-20 5:10 ` Grant Likely [this message]
2012-05-20 5:02 ` [PATCH v2 0/6] spi: s3c64xx: add support for device tree Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520051026.77D0C3E03B8@localhost \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).