* [PATCH] spi: Keep chipselect assertion during one message
@ 2012-05-23 12:34 Kyoungil Kim
[not found] ` <00a001cd38e0$57efde60$07cf9b20$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Kyoungil Kim @ 2012-05-23 12:34 UTC (permalink / raw)
To: spi-devel-general, linux-samsung-soc
Cc: 'Grant Likely', 'Kukjin Kim',
'Kyoungil Kim'
During all transfers in one message, the device will not be chagned.
So we don't need to deassert chipselect during one message.
Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
---
drivers/spi/spi-s3c64xx.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 972a94c..0f79f5b 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -745,8 +745,6 @@ static int s3c64xx_spi_transfer_one_message(struct spi_master *master,
if (list_is_last(&xfer->transfer_list,
&msg->transfers))
cs_toggle = 1;
- else
- disable_cs(sdd, spi);
}
msg->actual_length += xfer->len;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <00a001cd38e0$57efde60$07cf9b20$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] spi: Keep chipselect assertion during one message [not found] ` <00a001cd38e0$57efde60$07cf9b20$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2012-05-25 22:56 ` Grant Likely 0 siblings, 0 replies; 2+ messages in thread From: Grant Likely @ 2012-05-25 22:56 UTC (permalink / raw) To: Kyoungil Kim, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA Cc: 'Kukjin Kim', 'Kyoungil Kim' On Wed, 23 May 2012 21:34:06 +0900, Kyoungil Kim <ki0351.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: > During all transfers in one message, the device will not be chagned. > So we don't need to deassert chipselect during one message. > > Signed-off-by: Kyoungil Kim <ki0351.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Applied, thanks. g. > --- > drivers/spi/spi-s3c64xx.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 972a94c..0f79f5b 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -745,8 +745,6 @@ static int s3c64xx_spi_transfer_one_message(struct spi_master *master, > if (list_is_last(&xfer->transfer_list, > &msg->transfers)) > cs_toggle = 1; > - else > - disable_cs(sdd, spi); > } > > msg->actual_length += xfer->len; > -- > 1.7.1 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-25 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 12:34 [PATCH] spi: Keep chipselect assertion during one message Kyoungil Kim
[not found] ` <00a001cd38e0$57efde60$07cf9b20$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-05-25 22:56 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).