From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Florian Fainelli
<florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 1/3] spi/bcm63xx: remove driver version
Date: Fri, 25 May 2012 16:59:52 -0600 [thread overview]
Message-ID: <20120525225952.CFDCE3E0934@localhost> (raw)
In-Reply-To: <1337619960-9672-2-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
On Mon, 21 May 2012 19:05:58 +0200, Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> wrote:
> As Grant Likely reported, this does not make any sense in a mainline kernel
> remove that driver version string.
>
> Reported-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Signed-off-by: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-bcm63xx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 7491971..478eddc 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -36,7 +36,6 @@
> #include <bcm63xx_dev_spi.h>
>
> #define PFX KBUILD_MODNAME
> -#define DRV_VER "0.1.2"
>
> struct bcm63xx_spi {
> struct completion done;
> @@ -420,8 +419,8 @@ static int __devinit bcm63xx_spi_probe(struct platform_device *pdev)
> goto out_clk_disable;
> }
>
> - dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d) v%s\n",
> - r->start, irq, bs->fifo_size, DRV_VER);
> + dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d)\n",
> + r->start, irq, bs->fifo_size);
>
> return 0;
>
> --
> 1.7.9.5
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
next prev parent reply other threads:[~2012-05-25 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 17:05 [PATCH 0/3] spi/bcm63xx: drivers cleanups and fix Florian Fainelli
[not found] ` <1337619960-9672-1-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-21 17:05 ` [PATCH 1/3] spi/bcm63xx: remove driver version Florian Fainelli
[not found] ` <1337619960-9672-2-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 22:59 ` Grant Likely [this message]
2012-05-21 17:05 ` [PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks Florian Fainelli
[not found] ` <1337619960-9672-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 23:00 ` Grant Likely
2012-05-21 17:06 ` [PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer() Florian Fainelli
[not found] ` <1337619960-9672-4-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 23:00 ` Grant Likely
2012-06-27 22:26 ` [PATCH 0/3] spi/bcm63xx: drivers cleanups and fix Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2012-10-03 9:56 [PATCH 0/3] spi/bcm63xx: misc cleanups and fixes Florian Fainelli
[not found] ` <1349258215-27949-1-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-10-03 9:56 ` [PATCH 1/3] spi/bcm63xx: remove driver version Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525225952.CFDCE3E0934@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).