From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Florian Fainelli
<florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks
Date: Fri, 25 May 2012 17:00:05 -0600 [thread overview]
Message-ID: <20120525230005.5FFA43E0978@localhost> (raw)
In-Reply-To: <1337619960-9672-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
On Mon, 21 May 2012 19:05:59 +0200, Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> wrote:
> The PM callbacks implemented by the spi-bcm63xx driver don't call
> spi_master_{resume,suspend}, fix that.
>
> Signed-off-by: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-bcm63xx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 478eddc..85b0361 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -461,6 +461,8 @@ static int bcm63xx_spi_suspend(struct device *dev)
> platform_get_drvdata(to_platform_device(dev));
> struct bcm63xx_spi *bs = spi_master_get_devdata(master);
>
> + spi_master_suspend(master);
> +
> clk_disable(bs->clk);
>
> return 0;
> @@ -474,6 +476,8 @@ static int bcm63xx_spi_resume(struct device *dev)
>
> clk_enable(bs->clk);
>
> + spi_master_resume(master);
> +
> return 0;
> }
>
> --
> 1.7.9.5
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
next prev parent reply other threads:[~2012-05-25 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 17:05 [PATCH 0/3] spi/bcm63xx: drivers cleanups and fix Florian Fainelli
[not found] ` <1337619960-9672-1-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-21 17:05 ` [PATCH 1/3] spi/bcm63xx: remove driver version Florian Fainelli
[not found] ` <1337619960-9672-2-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 22:59 ` Grant Likely
2012-05-21 17:05 ` [PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks Florian Fainelli
[not found] ` <1337619960-9672-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 23:00 ` Grant Likely [this message]
2012-05-21 17:06 ` [PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer() Florian Fainelli
[not found] ` <1337619960-9672-4-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-05-25 23:00 ` Grant Likely
2012-06-27 22:26 ` [PATCH 0/3] spi/bcm63xx: drivers cleanups and fix Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2012-10-03 9:56 [PATCH 0/3] spi/bcm63xx: misc cleanups and fixes Florian Fainelli
[not found] ` <1349258215-27949-1-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-10-03 9:56 ` [PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525230005.5FFA43E0978@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).