From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer() Date: Fri, 25 May 2012 17:00:15 -0600 Message-ID: <20120525230015.513493E0984@localhost> References: <1337619960-9672-1-git-send-email-florian@openwrt.org> <1337619960-9672-4-git-send-email-florian@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Florian Fainelli , jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Florian Fainelli Return-path: In-Reply-To: <1337619960-9672-4-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Mon, 21 May 2012 19:06:00 +0200, Florian Fainelli wrote: > Calling bcm63xx_spi_check_transfer() with a NULL argument does not do > anything useful that the core spi code is not doing already, remove > this superfluous call. > > Signed-off-by: Florian Fainelli Applied, thanks. g. > --- > drivers/spi/spi-bcm63xx.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c > index 85b0361..1307833 100644 > --- a/drivers/spi/spi-bcm63xx.c > +++ b/drivers/spi/spi-bcm63xx.c > @@ -167,13 +167,6 @@ static int bcm63xx_spi_setup(struct spi_device *spi) > return -EINVAL; > } > > - ret = bcm63xx_spi_check_transfer(spi, NULL); > - if (ret < 0) { > - dev_err(&spi->dev, "setup: unsupported mode bits %x\n", > - spi->mode & ~MODEBITS); > - return ret; > - } > - > dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u nsec/bit\n", > __func__, spi->mode & MODEBITS, spi->bits_per_word, 0); > > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/