Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote:
> On Sun, May 20, 2012 at 2:21 AM, Mark Brown

> > This dev_name also isn't equivalent to dev_name() which makes matters
> > more confusing than they need to be.

> Looks like they use the name as the magic string to pick initialization data.

Right, and there's no problem at all with using the name.  The thing is
that there's no need to set the name at runtime since the struct device
being configured is always going to end up with the same name and doing
so is just causing confusion.  The device being registered is specific
to the SoC already so setting the SoC name at runtime isn't needed.

> I wonder if it makes more sense to keep the platform_data still
> around, and just fill it in with the table (from patch "spi: s3c64xx:
> move controller information into driver data") based on the OF
> compatible field for the device-tree probe case, instead of trying to
> overload and having to change the name in this way.

We could do that, though it does seem nice to have everything be
consistent.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]