From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver Date: Thu, 5 Jul 2012 01:20:07 +0200 Message-ID: <201207050120.08071.marex@denx.de> References: <1340958180-2291-1-git-send-email-marex@denx.de> <201207042340.55301.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Chris Ball , Wolfgang Denk , Detlev Zundel , Rob Herring , Stefano Babic , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Shawn Guo , Dong Aisheng , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Fabio Estevam Return-path: In-Reply-To: <201207042340.55301.marex-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Dear Marek Vasut, > Dear Fabio Estevam, > > > Hi Marek, > > > > On 6/29/12, Marek Vasut wrote: > > > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > > > - if (!iores) > > > + dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0); > > > + irq_err = platform_get_irq(pdev, 0); > > > + irq_dma = platform_get_irq(pdev, 1); > > > + if (!iores || irq_err < 0 || irq_dma < 0) > > > > Shouldn't you check for dmares < 0 here too? > > Yes. What about the rest of the patches? Are they applicable? (Lemme answer to myself) The DT documentation is missing. Ok, I'll send it in the next round. So any other comments please? :) > Best regards, > Marek Vasut Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/