From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Stefano Babic <sbabic-ynQEQJNshbs@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
Dong Aisheng <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28
Date: Thu, 5 Jul 2012 07:46:30 +0200 [thread overview]
Message-ID: <201207050746.30818.marex@denx.de> (raw)
In-Reply-To: <CAAQ0ZWQEoOy6etXhsy3uTPmiFqtVaqMf5VXUHFrp3O6R_jQ06g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Dear Shawn Guo,
> On 5 July 2012 13:39, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
> >> So SPI_MXS may need to select STMP_DEVICE.
> >
> > Ok, fixed in my tree. But, where's the meteor shower of nitpicks and such
> > stuff?
>
> I do not take this as a nitpick at all.
No, this one is valid. I mean the remaining stuff.
> Removing those drivers
> selecting STMP_DEVICE from mxs_defconfig, your driver does not
> compile.
Correct, this I fixed in my tree and will repost the series. I also fixed the
documentation issue. But ... what about the rest of the series, are you OK with
it as is ?
> Regards,
> Shawn
Best regards,
Marek Vasut
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
next prev parent reply other threads:[~2012-07-05 5:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 8:22 [PATCH 1/8] mmc: spi: Move SSP register definitions into separate file Marek Vasut
[not found] ` <1340958180-2291-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-06-29 8:22 ` [PATCH 2/8] mmc: spi: Rename IMX2[38]_MMC to IMX2[38]_SSP Marek Vasut
2012-06-29 8:22 ` [PATCH 3/8] mmc: spi: Add necessary bits into mxs-spi.h Marek Vasut
2012-06-29 8:22 ` [PATCH 4/8] mmc: spi: Pull out parts shared between MMC and SPI Marek Vasut
2012-06-29 8:22 ` [PATCH 5/8] mmc: spi: Pull out the SSP clock configuration function Marek Vasut
2012-06-29 8:22 ` [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28 Marek Vasut
2012-07-05 0:51 ` Shawn Guo
[not found] ` <20120705005143.GF2595-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-07-05 5:39 ` Marek Vasut
2012-07-05 5:43 ` Shawn Guo
[not found] ` <CAAQ0ZWQEoOy6etXhsy3uTPmiFqtVaqMf5VXUHFrp3O6R_jQ06g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-05 5:46 ` Marek Vasut [this message]
2012-07-05 5:51 ` Shawn Guo
[not found] ` <CAAQ0ZWQ-eQaN=R4ZoEeAD3yk+tBb7QQHdUHpOd0YeeYmkyi1kA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-05 6:00 ` Marek Vasut
2012-06-29 8:22 ` [PATCH 7/8] mmc: spi: Pull out common DMA parts from MXS MMC Marek Vasut
2012-06-29 8:23 ` [PATCH 8/8] mmc: spi: Add DMA support into SPI driver Marek Vasut
[not found] ` <1340958180-2291-8-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-06-29 13:49 ` Fabio Estevam
[not found] ` <CAOMZO5AN852f3Awv0UG+ApsgMC-x5ByQrLkUC5SkOnty5T0EMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-04 21:40 ` Marek Vasut
[not found] ` <201207042340.55301.marex-ynQEQJNshbs@public.gmane.org>
2012-07-04 21:43 ` Fabio Estevam
2012-07-04 23:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207050746.30818.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=sbabic-ynQEQJNshbs@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=wd-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).