From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28 Date: Thu, 5 Jul 2012 07:46:30 +0200 Message-ID: <201207050746.30818.marex@denx.de> References: <1340958180-2291-1-git-send-email-marex@denx.de> <201207050739.49912.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Wolfgang Denk , Detlev Zundel , Rob Herring , Stefano Babic , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Chris Ball , Dong Aisheng , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Guo Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Dear Shawn Guo, > On 5 July 2012 13:39, Marek Vasut wrote: > >> So SPI_MXS may need to select STMP_DEVICE. > > > > Ok, fixed in my tree. But, where's the meteor shower of nitpicks and such > > stuff? > > I do not take this as a nitpick at all. No, this one is valid. I mean the remaining stuff. > Removing those drivers > selecting STMP_DEVICE from mxs_defconfig, your driver does not > compile. Correct, this I fixed in my tree and will repost the series. I also fixed the documentation issue. But ... what about the rest of the series, are you OK with it as is ? > Regards, > Shawn Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/