From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
spi-devel-general@lists.sourceforge.net,
linux-samsung-soc@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()
Date: Thu, 5 Jul 2012 10:50:24 +0100 [thread overview]
Message-ID: <20120705095024.GL4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF55320.4020107@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Thu, Jul 05, 2012 at 10:41:04AM +0200, Sylwester Nawrocki wrote:
> It doesn't seem right. Why is is the check for valid sdd->regs removed ?
> This should have rather been:
Mostly just because the structure of the code is a bit error prone when
making quick updates with the if statement afterwards that looks like
error handling.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-05 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 16:11 [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap() Mark Brown
2012-07-04 16:11 ` [PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites Mark Brown
2012-07-05 8:41 ` [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap() Sylwester Nawrocki
2012-07-05 9:50 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 13:23 Mark Brown
2012-06-28 18:51 ` Linus Walleij
2012-06-29 1:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705095024.GL4111@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).