From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [06/10,V2] spi: Add SPI driver for mx233/mx28 Date: Wed, 1 Aug 2012 08:10:37 +0200 Message-ID: <201208010810.37652.marex@denx.de> References: <1341555449-17507-6-git-send-email-marex@denx.de> <20120801054228.GA2645@roeck-us.net> <20120801062838.GF1672@S2100-06.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Stefano Babic , Rob Herring , Guenter Roeck , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Chris Ball , Dong Aisheng , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Guo Return-path: In-Reply-To: <20120801062838.GF1672-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Dear Shawn Guo, > On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote: > > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote: > > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote: > > > > Anyone up for writing some patches ? If not, I'll do it. > > > > > > Go ahead. > > > > Ok, will do. It isn't that simple, actually, since at least some of the > > drivers also call spi_master_get(), and thus need two calls to > > spi_master_put() (or a call to spi_master_put and a call to kfree). > > Hmm, are you saying that there must be a spi_master_put call matching > spi_alloc_master? I think we only need to have spi_master_get and > spi_master_put matched. Naw, spi_master_get() does refcounting, spi_alloc_master() doesnt. You don't need to match spi_alloc_master() with spi_master_put() > Regards, > Shawn Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/