linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: spi-bcm63xx: Pass NULL to platform_set_drvdata
@ 2012-08-16 10:44 Tobias Klauser
       [not found] ` <1345113878-9626-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2012-08-16 10:44 UTC (permalink / raw)
  To: Grant Likely, Mark Brown
  Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

platform_set_drvdata expects a void *, so pass NULL instead of 0.

Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
---
 drivers/spi/spi-bcm63xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 6d97047..fc357e2 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -463,7 +463,7 @@ static int __devexit bcm63xx_spi_remove(struct platform_device *pdev)
 	clk_disable(bs->clk);
 	clk_put(bs->clk);
 
-	platform_set_drvdata(pdev, 0);
+	platform_set_drvdata(pdev, NULL);
 
 	spi_master_put(master);
 
-- 
1.7.5.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi: spi-bcm63xx: Pass NULL to platform_set_drvdata
       [not found] ` <1345113878-9626-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
@ 2012-08-16 10:45   ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-08-16 10:45 UTC (permalink / raw)
  To: Tobias Klauser; +Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Thu, Aug 16, 2012 at 12:44:38PM +0200, Tobias Klauser wrote:
> platform_set_drvdata expects a void *, so pass NULL instead of 0.
> 
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>

Better yet, remove these calls - they're completely redundant.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-16 10:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-16 10:44 [PATCH] spi: spi-bcm63xx: Pass NULL to platform_set_drvdata Tobias Klauser
     [not found] ` <1345113878-9626-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2012-08-16 10:45   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).